Avoid pickling the same position multiple times #3828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ class PositionPickler(pickler: TastyPickler, addrOfTree: tpd.Tree => Option[Addr | |||
| import buf._ | |||
| import ast.tpd._ | |||
|
|
|||
| private val remainingAddrs = new java.util.IdentityHashMap[Tree, Iterator[Addr]] | |||
| private val pickledIndices = new mutable.HashSet[Int] | |||
There was a problem hiding this comment.
Yes, this looks ideal for a BitSet, since it is bounded and fairly dense.
Decreases the size of the bootstrapped dotty-compiler jar from 8662 KB to 8647 KB.
smarter
force-pushed
the
pickle-less-pos
branch
from
368ef38 to
0c7305a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decreases the size of the bootstrapped dotty-compiler jar from 8662 KB
to 8647 KB.