Fix of #375 - adapt returned value in erasure #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -715,7 +715,15 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit | |||
| } | |||
| val (from, proto) = | |||
| if (tree.from.isEmpty) enclMethInfo(ctx) | |||
| else (tree.from.asInstanceOf[tpd.Tree], WildcardType) | |||
| else { | |||
| val from = tree.from.asInstanceOf[tpd.Tree] | |||
There was a problem hiding this comment.
Are we sure that after erasure tree.from is not an EmptyTree?
There was a problem hiding this comment.
Why does that matter?
|
LGTM, thanks |
DarkDimius
added a commit
that referenced
this pull request
Feb 27, 2015
Fix of #375 - adapt returned value in erasure
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
May 2, 2025
Revert "Do not lift annotation arguments" from 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix of #375. @DarkDimius can you take a look?