Encode large quotes #3819
Merged
Encode large quotes #3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase |
odersky
reviewed
Jan 13, 2018
| @@ -8,7 +8,7 @@ object Unpickler { | |||
| /** Representation of pickled trees. For now it's String, but it | |||
There was a problem hiding this comment.
I'd probably make it a List[String] instead. SeqLiterals are expensive but :: is cheap. So single string quotes could be represented as quoted :: Nil
Overcome the limitations of maximum String byte length of 65535.
nicolasstucki
force-pushed
the
encode-large-quotes
branch
from
24a7a19 to
b53d3ff
Compare
odersky
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3685