Fix #2333: Check if class is deprecated #3811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about this instead? diff --git a/compiler/src/dotty/tools/dotc/typer/RefChecks.scala b/compiler/src/dotty/tools/dotc/typer/RefChecks.scala
index aaadbb66e..36ab320d7 100644
--- a/compiler/src/dotty/tools/dotc/typer/RefChecks.scala
+++ b/compiler/src/dotty/tools/dotc/typer/RefChecks.scala
@@ -879,6 +879,7 @@ class RefChecks extends MiniPhase { thisPhase =>
}
override def transformNew(tree: New)(implicit ctx: Context) = {
+ checkUndesiredProperties(tree.tpe.typeSymbol, tree.pos)
currentLevel.enterReference(tree.tpe.typeSymbol, tree.pos)
tree
} |
allanrenucci
approved these changes
Jan 11, 2018
| @@ -879,6 +879,7 @@ class RefChecks extends MiniPhase { thisPhase => | |||
| } | |||
|
|
|||
| override def transformNew(tree: New)(implicit ctx: Context) = { | |||
| checkUndesiredProperties(tree.tpe.typeSymbol, tree.pos) | |||
| currentLevel.enterReference(tree.tpe.typeSymbol, tree.pos) | |||
There was a problem hiding this comment.
Maybe store tree.tpe.typeSymbol in a temporary val
tests/neg-custom-args/i2333.scala
Outdated
|
|
||
| object Test { | ||
| new Foo // error | ||
| } |
There was a problem hiding this comment.
I would also slightly modify the test, to test secondary constructors:
@deprecated("bla", "2.11.0") class Foo {
def this(x: Int) = this()
}
object Test {
new Foo // error: deprecated
new Foo(1) // error: deprecated
}
|
Sorry for the multiple paths 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.