-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #2909: Port per-phase profiling from scalac #3801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the output of compiling the collection strawman
|
The "single" and "total" lines in your table are identical |
That is the format that it produces. I guess it would be possible to have multiple runs on the same phase and then the total would be different. |
Isn't total supposed to be the total of all phases until now? |
The same is printed by scalac |
Just as you're doing this PR, changes are happening on the scalac side: scala/scala#6264 :). |
You have missed some other changes - scala/scala#6264 is an extra column but I think that you are missing scala/scala#6200 total ( now removed) was the total including background threads created via the async helper - but you will not get any until you get the backend chnages in scala/scala#6124 which is not merged |
3f4418c
to
b03551d
Compare
Now it looks like
|
44fd89f
to
21b0149
Compare
21b0149
to
7eb4dd5
Compare
Ported from scala/scala#5848