Fix/#34 pathresolvers #38
Conversation
Right now this one fails.
The root cause of scala#34 was that we took a type argument which was an existential type. These are returned as type bounds, which make no sense in the calling context. To avoid that problem in the future, `typeArgs` got renamed to `argInfos`, so it is clear we get an info, not necessarily a value type. There are also added method `argTypes`, `argTypesLo`, `argTypesHi`, which return a type, but either throw an exception or return a lower/upper approximation of the argument is an existential type. There's another issue that the existential type only arose when compiling the same couple fo files the seciond time. We need to chase that one down separately.
|
Otherwise OK for me. |
|
The trace can stay enabled. We can include the test case in the commit the next time. for now I would prefer to just get the build back to work, so I am not resubmitting. |
|
testIssue_34 seems to tests this particular issue. https://github.com/lampepfl/dotty/pull/38/files#diff-28f8d722cae3da74d903fc63040c9d36R74 LGTM, as a quickfix for #34 |
|
Yes, it would be good to minimize the test case further. The other thing we still need to do is find out why the problem manifested itself only on a resident recompile. That should not be the case. For that reason also it's good to leave the failing test case in a separate commit. Easier to come back to it that way. |
Merge Changes from Dotty Upstream
Backport "Backport changes for the presentation compiler from Metals" to 3.3 LTS
See explanation in commits.
Review by @DarkDimius, @srjd