Skip to content

Added error message for Symbol is not a value #1589 #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added error message for Symbol is not a value #1589 #3746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9446ce3
Missing error messages #1589
benkobalog Jan 4, 2018
8311e91
Changing SymbolIsNotAValue to JavaSymbolIsNotAValue
benkobalog Jan 4, 2018
6c296d1
Changed explanation for JavaSymbolIsNotAValue
benkobalog Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ public enum ErrorMessageID {
SymbolChangedSemanticsInVersionID,
UnableToEmitSwitchID,
MissingCompanionForStaticID,
SymbolIsNotAValueID,
;

public int errorNumber() {
Expand Down
9 changes: 8 additions & 1 deletion compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ object messages {

case class WildcardOnTypeArgumentNotAllowedOnNew()(implicit ctx: Context)
extends Message(WildcardOnTypeArgumentNotAllowedOnNewID) {
val kind = "syntax"
val kind = "Syntax"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only place where this string started with a lowercase. I assumed it was a typo, if somebody could confirm it, it would be good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

val msg = "type argument must be fully defined"

val code1 =
Expand Down Expand Up @@ -2064,4 +2064,11 @@ object messages {
val explanation =
hl"An object that contains ${"@static"} members must have a companion class."
}

case class SymbolIsNotAValue(symbol: Symbol)(implicit ctx: Context) extends Message(SymbolIsNotAValueID) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SymbolIsNotAValue -> JavaSymbolIsNotAValue
Same for ID.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the class name, ID and test name too.

val msg = hl"${symbol.show} is not a value"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need show here $symbol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the show method.

val kind = "Type Mismatch"
val explanation =
hl"Scala or Java packages cannot be assigned to a value"
Copy link
Contributor

@nicolasstucki nicolasstucki Jan 4, 2018 •
edited by allanrenucci
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala packages can be used as values if they have a package object.

Java statics and packages cannot be used as a value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be the explanation then?
What are Java statics in this context? I guess not static fields because """object O {val a = Math.PI}""" compiles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the relevant conversation. I will write a better explanation based on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the explanation.

}
}
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Checking.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ trait Checking {
val sym = tree.tpe.termSymbol
// The check is avoided inside Java compilation units because it always fails
// on the singleton type Module.type.
if ((sym is Package) || ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(em"$sym is not a value", tree.pos)
if ((sym is Package) || ((sym is JavaModule) && !ctx.compilationUnit.isJava)) ctx.error(SymbolIsNotAValue(sym), tree.pos)
}
tree
}
Expand Down
14 changes: 14 additions & 0 deletions compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,4 +1277,18 @@ class ErrorMessagesTests extends ErrorMessagesTest {
val MissingCompanionForStatic(member) = messages.head
assertEquals(member.show, "method bar")
}

@Test def symbolIsNotAValue =
checkMessagesAfter("checkStatic") {
"""
|package p
|object O {
| val v = p
|}
""".stripMargin
}.expect { (itcx, messages) =>
implicit val ctx: Context = itcx
val SymbolIsNotAValue(symbol) = messages.head
assertEquals(symbol.show, "package p")
}
}