Add error message for polymorphic methods in structured refinements #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jan 3, 2018
allanrenucci
suggested changes
Jan 4, 2018
| @@ -2064,4 +2064,14 @@ object messages { | |||
| val explanation = | |||
| hl"An object that contains ${"@static"} members must have a companion class." | |||
| } | |||
|
|
|||
| case class PolymorphicMethodMissingTypeInParent(rsym: Symbol, parentTpt: tpd.Tree)(implicit ctx: Context) | |||
There was a problem hiding this comment.
I would pass parentTpt as a Symbol.
| val msg = hl"polymorphic refinement $rsym without matching type in parent $parentTpt is no longer allowed" | ||
| val explanation = | ||
| hl"""Polymorphic $rsym is not allowed in the structural refinement of $parentTpt because | ||
| |$rsym does not override any symbol in $parentTpt. Structural refinement does not allow for |
allanrenucci
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Typer.scala:1109in #1589. Polymorphic methods are not allowed in structural refinements as explained here: https://github.com/lampepfl/dotty/blob/88d016c6f0d991698a42bfca2d593f8ec1ae608d/docs/docs/reference/changed/structural-types.md#notes