Fix #3433: Fix determining typeParams for structural type members #3733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jan 4, 2018
| @@ -172,6 +172,7 @@ class TypeApplications(val self: Type) extends AnyVal { | |||
| case self: TypeRef => | |||
| val tsym = self.symbol | |||
| if (tsym.isClass) tsym.typeParams | |||
| else if (!tsym.exists) self.info.typeParams | |||
There was a problem hiding this comment.
.How come we don't have the symbol for the refinement member here? That seems likely to be problematic in a lot of other cases, for example in the IDE how do we do "go to definition" if the tree has no symbol?
There was a problem hiding this comment.
Refinements of types that do not exist in the baseclass don't have a symbol. Which symbol could they have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.