Skip to content

Fix #1207: Add Batch scripts and improve Shell scripts #3720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix #1207: Add Batch scripts and improve Shell scripts #3720

wants to merge 2 commits into from

Conversation

floating-cat
Copy link

No description provided.

* Remove unneeded SHA trim (The Scala code have already used `String#subString` to get the needed length. It would be better to let the user choose the length they need.).
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@floating-cat
Copy link
Author

retest this please

@smarter
Copy link
Member

smarter commented Dec 31, 2017

Hi @floating-cat and thanks for the PR! I don't think there's any way to redo the CLA check on the PR, but that's OK, I've manually checked on https://www.lightbend.com/contribute/cla/scala/check/floating-cat that you have signed the CLA.

@floating-cat
Copy link
Author

floating-cat commented Dec 31, 2017

Thanks. This pull request is ready for review.
Though I am not sure who would like to review.

@allanrenucci
Copy link
Contributor

I think #1207 refers to windows version of dist/{dotc, dotd, dotr}.

Also, I think a better solution here is to get rid of the project/scripts/build/... scripts and reimplement project/VersionUtil.scala using JGit. You can look at what scalac does: https://github.com/scala/scala/blob/2.13.x/project/VersionUtil.scala#L55-L86

@floating-cat
Copy link
Author

You are right, reimplement VersionUtil using JGit is better.
So I close this PR. If I have time to redone this, I would open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants