Add missing case to TypeComparer #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing case was for hk-type ref <:< hk type lambda E.g. type Y[X] Foo[Y] <:< Foo[[T] => Y[T]]
smarter
approved these changes
Dec 30, 2017
| if (tp1.isHK) { | ||
| val tparams1 = tp1.typeParams | ||
| return isSubType( | ||
| HKTypeLambda.fromParams(tparams1, tp1.appliedTo(tparams1.map(_.paramRef))), |
There was a problem hiding this comment.
Can be written EtaExpansion(tp1) I think.
There was a problem hiding this comment.
EtaExpansion only works for class type constructors. I tried to change that, but it would be quite involved, so I thought it was simpler to write the code directly here.
| @@ -1065,7 +1065,7 @@ object desugar { | |||
| AppliedTypeTree(ref(seqType), t), | |||
| New(ref(defn.RepeatedAnnotType), Nil :: Nil)) | |||
| } else { | |||
| assert(ctx.mode.isExpr || ctx.reporter.hasErrors, ctx.mode) | |||
| assert(ctx.mode.isExpr || ctx.reporter.hasErrors || ctx.mode.is(Mode.Interactive), ctx.mode) | |||
There was a problem hiding this comment.
Any idea why we manage to hit this assertion in the IDE?
There was a problem hiding this comment.
No idea, I am afraid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing case was for
E.g.