Skip to content

Fix #2081: Don't issue an $init$ method for NoInits traits #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2017
Merged

Fix #2081: Don't issue an $init$ method for NoInits traits #3712

merged 2 commits into from
Dec 31, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 30, 2017

  • Don't issue an initializer is a trait does not need initialization,
    as signalled by NoInits
  • Don't overwrite NoInits in erasure since that gives the wrong information
  • Don't issue supercalls in Mixin to NoInits traits

@odersky
Fix scala#2081: Don't issue an $init$ method for NoInits traits
e6e81d6 
 - Don't issue an initializer is a trait does not need initialization,
   as signalled by NoInits
 - Don't overwrite NoInits in erasure since that gives the wrong information
 - Don't issue supercalls in Mixin to NoInits traits
@odersky odersky requested a review from smarter December 30, 2017 12:49
smarter
smarter approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed a commit to make testNoInit.scala check whether the method is present or not.

@smarter smarter merged commit 6a46b07 into scala:master Dec 31, 2017
@allanrenucci allanrenucci deleted the fix-#2081-noinits branch January 1, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @smarter