Skip to content

Add regression tests for #3594 #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

smarter
smarter previously approved these changes Dec 22, 2017
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, wouldn't it be easier to compile every pos test from tasty except for a set of blacklisted files?

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Dec 22, 2017

Yes, I will change it to a blacklist.

Run all `pos` and `run` tests from TASTY with an explicit blacklist
@nicolasstucki nicolasstucki force-pushed the regeression-tests-for-#3594 branch from d16b613 to 90c6146 Compare December 22, 2017 15:08
@nicolasstucki nicolasstucki dismissed smarter’s stale review December 22, 2017 15:09

The implementation changed completely, needs re-review

@nicolasstucki nicolasstucki merged commit d4bb969 into scala:master Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants