Skip to content

Fix to testLifted #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Fix to testLifted #361

merged 1 commit into from
Mar 18, 2015

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Feb 11, 2015

If the original type does not have the right type parameters, look in the baseclasses.
Previously this was done only if the original type did not have any type parameters.

Review by @smarter

If the original type does not have the right type parameters, look in the baseclasses.
Previously this was done only if the original type did not have any type parameters.
@@ -509,7 +509,7 @@ class TypeApplications(val self: Type) extends AnyVal {
* { type $hkArg$0 = T1; ...; type $hkArg$n = Tn }
*
* satisfies predicate `p`. Try base types in the order of their occurrence in `baseClasses`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation still seems incomplete, we don't always check that there is a base type where the type parameters match tparams, and there's a special case when tparams.isEmpty.

DarkDimius added a commit that referenced this pull request Mar 18, 2015
@DarkDimius DarkDimius merged commit 8cf176a into scala:master Mar 18, 2015
DarkDimius added a commit to dotty-staging/dotty that referenced this pull request Mar 18, 2015
@allanrenucci allanrenucci deleted the fix/testLifted branch December 14, 2017 19:23
tgodzik added a commit to tgodzik/scala3 that referenced this pull request Apr 29, 2025
Backport "Update asm to 9.8.0" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants