Skip to content

Do not clean the sbt bridge cache on every bootstrapped compile #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

smarter
Copy link
Member

@smarter smarter commented Nov 29, 2017

Previously, any compilation of a bootstrapped project removed the sbt
bridge cache which then had to be recompiled. This is too extreme: we
should only do it when the bridge needs to be recompiled.

Previously, any compilation of a bootstrapped project removed the sbt
bridge cache which then had to be recompiled. This is too extreme: we
should only do it when the bridge needs to be recompiled.
@smarter smarter requested a review from allanrenucci November 29, 2017 17:34
@allanrenucci allanrenucci requested review from Duhemm and removed request for allanrenucci November 29, 2017 18:58
Copy link
Contributor

@Duhemm Duhemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if I understand correctly:

  • Doing a bootstrapped compile always packages the sources of bridge so that sbt can then compile it.
  • This used to clean the bridge each time.
  • Now we only clean the bridge when we explicitly want to compile it.

@smarter
Copy link
Member Author

smarter commented Nov 29, 2017

Yes, exactly :).

@smarter smarter merged commit 868fc9b into scala:master Nov 29, 2017
@allanrenucci allanrenucci deleted the fix-sbt-bridge-clean branch November 29, 2017 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants