Fix dotr for Cygwin and MingW #3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test for the fix is green: lampepfl/packtest#8 |
allanrenucci
suggested changes
Nov 29, 2017
dist/bin/dotr
Outdated
| fi | ||
| echo "Starting dotty REPL..." | ||
| eval "$PROG_HOME/bin/dotc $cp_arg -repl ${residual_args[@]}" | ||
| eval "$PROG_HOME/bin/dotc -classpath \"$cp_arg\" -repl ${residual_args[@]}" |
There was a problem hiding this comment.
The semantic is different here. Now if you pass no classpath, you will run dotc -classpath "" ...,
before dotc .... dotc is not happy if you pass an empty classpath
There was a problem hiding this comment.
I've updated the PR, and added a test to packtest to guard against regression for empty classpath: https://github.com/lampepfl/packtest/pull/9/files
allanrenucci
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the dotr script for Cygwin and MingW.
@allanrenucci : Is it possible to run a service on test machine to listen for commands like "test scripts please" or "test community build" please? If it's possible, I'm motivated to write such scripts.