Fix file change detection in dotc & dotr scripts #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`>&` redirects both stdout and stderr, here we *need* `stdout` for the test below but don't care about `stderr`: when `dist-bootstrapped/target/pack/VERSION` doesn't exists, users don't should't see the error from find. Also testing for the existance of `$target` to rebuild dotty is obviously a typo, we want to rebuild `$version` is not on disk.
allanrenucci
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the file change detection in the dotc & dotr scripts.
>&redirects both stdout and stderr, here we needstdoutfor the test below but don't care aboutstderr: whendist-bootstrapped/target/pack/VERSIONdoesn't exists, users don't should't see the error from find.Also testing for the existance of
$targetto rebuild dotty is obviously a typo, we want to rebuild$versionis not on disk.