Fix #3548: set outer select type to be the type enclosing the expected type #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/run/i3548.scala
Outdated
| case O2.Data(s) => println("O2 data") | ||
| case _ => println("Unknown") | ||
| } | ||
| } |
There was a problem hiding this comment.
I propose a slight modification to the test:
val result = data match {
case O1.Data(s) => 1
case O2.Data(s) => 2
case _ => 3
}
assert(result == 2)
…pected type Otherwise, ElimOuterSelect will insert `ensureConforms(tp)` in outer test, which causes run-time exeception.
|
I had doubts at first, but after looking into it more deeply this appears to be the right fix. LGTM |
odersky
approved these changes
Dec 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3548: set outer select type to be the type enclosing the expected type.
Otherwise,
ElimOuterSelectwill insertensureConforms(tp)in outer test, which causes run-time exception.