Fix/capturedvars #354
Merged
Fix/capturedvars #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an object Util for utility methods that are used in several places.
|
I accidentally slipped another change into this PR (Make line search logic in SourcePositions generally available). But that's OK. We want to do that anyway. |
odersky
force-pushed
the
fix/capturedvars
branch
from
b15d4e5 to
b6efacf
Compare
| * as the first search point, otherwise use | ||
| * `candidates.length/2`. | ||
| * @pre candidates is sorted | ||
| * @pre candidates(0) <= x |
There was a problem hiding this comment.
The second precondition should not be there, since you specify what happens if it's not true, i.e., the method must return -1. (as opposed to: it crashes or loops indefinitely)
|
That's all I have. LGTM for the commit about the mutable flag. |
|
Thanks for the quick review! |
| if (x < candidates(mid)) | ||
| recur(lo, mid - 1, (lo + mid - 1) / 2) | ||
| else if (mid + 1 < candidates.length && x >= candidates(mid + 1)) | ||
| recur(mid + 1, hi, (mid + 1 + hi) / 2) |
There was a problem hiding this comment.
This is prone to overflow (http://googleresearch.blogspot.com.au/2006/06/extra-extra-read-all-about-it-nearly.html).
Of course we're unlikely to deal with a source file long enough to hit the problem :)
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "improvement: Support using directives in worksheets" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by @sjrd