Fix #3515: Do not save tasty in .class with -YemitTasty #3517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only emit .tasty file
|
We are currently not loading tasty from the |
| if (attrLen == 0) { | ||
| // A tasty attribute implies the existence of the .tasty file | ||
| val tastyFilePath = | ||
| classfile.jpath.resolveSibling(classfile.jpath.getFileName.toString.dropRight("class".length) + "tasty") |
There was a problem hiding this comment.
io.File(classfile.jpath).changeExtension("tasty")
nicolasstucki
force-pushed
the
fix-#3515
branch
from
df20ecd to
41f6215
Compare
smarter
approved these changes
Nov 22, 2017
|
We have them in the idempotency tests, that is why ed61847 failed the tests. |
|
I will create one test that will execute in local tests. Idempotency tests only run on the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only emit .tasty file