Add error message for wrong number of argument patterns #3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 20, 2017
| assertMessageCount(1, messages) | ||
| val UnapplyInvalidNumberOfArguments(qual, argTypes) :: Nil = messages | ||
| assertEquals("Boo", qual.show) | ||
| assertEquals("(class Int, class String)", s"(${argTypes.map(_.typeSymbol).mkString(", ")})") |
There was a problem hiding this comment.
Use argTypes.map(_.typeSymbol).mkString("(", ", ", ")") instead of s"(${argTypes.map(_.typeSymbol).mkString(", ")})".
| |Expected usage would be something like: | ||
| |case $qual(${argTypes.map(_ => '_')}%, %) => ... | ||
| | | ||
| |where subsequent arguments would have following types: ($argTypes%, %).""".stripMargin |
There was a problem hiding this comment.
""".stripMargin should be on the next line.
There was a problem hiding this comment.
The issue with stripMargin being on the next line is that it adds an extra line to the explanation which is not desired.
There was a problem hiding this comment.
@nicolasstucki @allanrenucci can you please decide which option is recommended? I will gladly oblige.
Also - whoever does the merge can fix it as I have checked 'Allow edits from maintainers'.
gosubpl
force-pushed
the
wip/1589-unapply-invalid-number-args-2
branch
from
ce1313e to
e5e9270
Compare
|
@nicolasstucki thanks for such a quick review! I have reflected your comments. |
nicolasstucki
approved these changes
Nov 21, 2017
|
Many thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1589