For some tests context is required, it should be passed to checker phase... #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have said LGTM but Travis failed. |
|
It died due to #34 |
DarkDimius
added a commit
that referenced
this pull request
Mar 3, 2014
For some tests context is required, it should be passed to checker phase.
noti0na1
pushed a commit
to noti0na1/dotty
that referenced
this pull request
Oct 29, 2019
Merge Changes from Dotty Upstream
odersky
referenced
this pull request
in dotty-staging/dotty
Jun 10, 2022
Some tests by Matt had cases where `.nn` figured prominently in the flamegraph.
I optimized it so that the fast path is streamlined and inlined.
In the following test code:
```
def x: String | Null = "abc"
val y = x.nn
```
the new implementation is
```
10: getstatic #20 // Field MODULE$:LTest$;
13: invokevirtual #24 // Method x:()Ljava/lang/String;
16: astore_0
17: getstatic #29 // Field scala/runtime/Scala3RunTime$.MODULE$:Lscala/runtime/Scala3RunTime$;
20: aload_0
21: invokevirtual #33 // Method scala/runtime/Scala3RunTime$.nn:(Ljava/lang/Object;)Ljava/lang/Object;
24: checkcast #35 // class java/lang/String
27: putstatic #37 // Field y:Ljava/lang/String;
```
The previous implementation was two bytes shorter, but contained in the critical path
- A call to a ScalaRuntime method, which was not inlineable by the JIT compiler due to its size,
- A conversion of a cmparison to a Boolean value (not sure this matters)
- A cast from the return type `Object` to the actual type.
bishabosha
referenced
this pull request
in dotty-staging/dotty
Oct 18, 2022
Some tests by Matt had cases where `.nn` figured prominently in the flamegraph.
I optimized it so that the fast path is streamlined and inlined.
In the following test code:
```
def x: String | Null = "abc"
val y = x.nn
```
the new implementation is
```
10: getstatic #20 // Field MODULE$:LTest$;
13: invokevirtual #24 // Method x:()Ljava/lang/String;
16: astore_0
17: getstatic #29 // Field scala/runtime/Scala3RunTime$.MODULE$:Lscala/runtime/Scala3RunTime$;
20: aload_0
21: invokevirtual #33 // Method scala/runtime/Scala3RunTime$.nn:(Ljava/lang/Object;)Ljava/lang/Object;
24: checkcast #35 // class java/lang/String
27: putstatic #37 // Field y:Ljava/lang/String;
```
The previous implementation was two bytes shorter, but contained in the critical path
- A call to a ScalaRuntime method, which was not inlineable by the JIT compiler due to its size,
- A conversion of a cmparison to a Boolean value (not sure this matters)
- A cast from the return type `Object` to the actual type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @sjrd @odersky