Upgrade ASM to 6.0, fix bug with very large methods #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allanrenucci Could you take care of upgrading the CI cache please? |
smarter
force-pushed
the
upgrade/asm-6.0
branch
from
634cc0d to
50c7b33
Compare
|
CI failed because of a timeout, maybe because it was overloaded (http://tresormon.epfl.ch/munin/epfl.ch/lampsrv9.epfl.ch/cpu.html), I'll rerun it. |
|
Hah, I see. The issue is that dotty simplifier tries really hard to optimize the added testcase :). |
Adapted from scala/scala#6180 by Lukas Rytz, the test case demonstrates that scala/bug#10594 is fixed. The test case is put in tests/run-no-optimise because the optimiser runs forever on this code.
smarter
force-pushed
the
upgrade/asm-6.0
branch
from
d79de15 to
2761b63
Compare
allanrenucci
approved these changes
Nov 19, 2017
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from scala/scala#6180 by Lukas Rytz, the
test case demonstrates that scala/bug#10594 is fixed.