Avoid boxing FlagSets in union and allOf #3497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Nov 17, 2017
| def union(flagss: FlagSet*) = (EmptyFlags /: flagss)(_ | _) | ||
| def union(flagss: FlagSet*): FlagSet = { | ||
| var flag = EmptyFlags | ||
| for (f <- flagss) |
There was a problem hiding this comment.
If you want to go deep in micro-optimizations, you could use a while loop
There was a problem hiding this comment.
Should avoid FlagSet* altogether.
smarter
reviewed
Nov 17, 2017
| @@ -172,12 +172,24 @@ object Flags { | |||
| } | |||
|
|
|||
| /** The union of all flags in given flag set */ | |||
| def union(flagss: FlagSet*) = (EmptyFlags /: flagss)(_ | _) | |||
| def union(flagss: FlagSet*): FlagSet = { | |||
There was a problem hiding this comment.
This is still going to box, isn't it? FlagSet* becomes Seq[FlagSet], value classes in generic positions are always boxed.
There was a problem hiding this comment.
We avoid reboxing in the fold, half of the boxes are gone.
|
test performance please |
|
I do not believe the performance should change much |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3497/ to see the changes. Benchmarks is based on merging with master (b95e71a) |
OlivierBlanvillain
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping dotty, this reduces the allocated
FlagSetsfrom 2.7M to 400K.