Skip to content

Fix an imperative mood rule example #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix an imperative mood rule example #3482

merged 1 commit into from
Nov 16, 2017

Conversation

maseev
Copy link
Contributor

@maseev maseev commented Nov 15, 2017

This PR fixes the imperative mood rule example in the PullRequestService.scala. There's a discussion that explains the main point of this fix.

allanrenucci
allanrenucci approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@allanrenucci allanrenucci merged commit 01c533f into scala:master Nov 16, 2017
@maseev maseev deleted the fix-imperative-mood-rule branch November 16, 2017 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maseev @allanrenucci