[WIP] Resurrect the Scala.js backend #3481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 06a3d47 to bring back Dotty.js from the dead. Many things are broken still, but this is enough to do some experiments: - The backend was initially removed because of scala#1574, I don't see why GetClass has a requirement on FunctionalInterfaces, so I just removed it ¯\_(ツ)_/¯ - Scala.js was upgraded to 0.6.19. More recent versions of Scala.js cannot be used because they require sbt 0.13.16 and we're blocked by sbt/sbt#3460, this won't be an issue anymore once we switch to sbt 1 (see scala#3441) - GenSJSIR was hacked to compile with 0.6.19 but is missing most of the changes to the Scala.js backend phase for Scala 2 that happened since it was initially ported to Dotty from Scala.js 0.6.8 - scalajs-ir does not compile with Dotty anymore, see comments in Build.scala - The Scala.js backend explodes when extending a Scala 2 trait because of the way LinkScala2Impls transforms supercalls to these traits. Luckily, we don't need to extend js.JSApp anymore to make a Hello World :P. I verified that the following works: sbt sjsSandbox/run But I don't know if anything else does!
For some reason if we don't do that we get cyclic reference errors, this will need to be investigated.
|
Closing this for now as outdated — hopefully somebody (@sjrd?) will resurrect it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy birthday @sjrd 😛
This partially reverts 06a3d47 to bring
back Dotty.js from the dead. Many things are broken still, but this is
enough to do some experiments:
GetClass has a requirement on FunctionalInterfaces, so I just removed
it ¯\_(ツ)_/¯
used because they require sbt 0.13.16 and we're blocked by
com.typesafe.sbt:sbt-interface:0.13.16 is not published sbt/sbt#3460, this won't be an issue anymore
once we switch to sbt 1 (see Upgrade to sbt 1 #3441)
changes to the Scala.js backend phase for Scala 2 that happened
since it was initially ported to Dotty from Scala.js 0.6.8
of the way LinkScala2Impls transforms supercalls to these traits.
Luckily, we don't need to extend js.JSApp anymore to make a Hello World :P.
I verified that the following works:
sbt sjsSandbox/runBut I don't know if anything else does!