Remove vulpix reflective nightmare

[nicolasstucki]

No description provided.

[smarter]

You shouldn't need to give an explicit type signature here because the implicit val is in a def.

[nicolasstucki]

Do you want me to remove them? I added them to avoid warnings from the IDE.

[smarter]

Your call.

[allanrenucci]

Can you explain what a test group is and what it is used for

[nicolasstucki]

It is used as the name of the first level of folder nesting in the output of the tests. For example all output of @Test def runAll = ... will be out/runAll. Inner folders are determined by the kind of tests you are executing. Previously the group name was generated by reflection inspecting the name of the method it was in, this was unnecessary, brittle and hard to understand in the cases where compilation tests depended on previous ones such as @Test def tastyBootstrap. In that case the inner defs where only present to give the group name to substeps of the tests and refactoring easily broke the expected output paths.

[allanrenucci]

I think it’s weird that outputDirecrory is not the actual output directory. It is also weird to add a new abstraction just to specify the output directory. Also we now have test group and test category that are two completely different things
Can we just use the existing outputdirectory parameter?

[nicolasstucki]

The test group was also used to determine the title of the tests. I wonder if we could instead remove the outputdirectory parameter.

[nicolasstucki]

Yes, the output directory was only used twice and was API overkill.

[smarter]

Please document what a TestGroup is.

[nicolasstucki]

Done