Fix #3422: Add missing case to TypeComparer #3428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed the case where we compare two hk tpes A <: B, where both A and B refer to classes with type parameters. It seems this case usually does not arise when we compile from source because A or B or both are eta expanded. But it can arise after unpickling.
|
@smarter Ready to merge? |
|
I'll review it today |
|
LGTM, although I wonder if we should take a step back and try to fix our higher-kinded subtyping checks in a more systematic way. #2989 is a very similar issue which is still broken after this PR. I have a tentative fix at https://github.com/dotty-staging/dotty/commits/fix-eta-expansion-new but I'm not convinced it's the right thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed the case where we compare two hk tpes A <: B, where both A and B refer to
classes with type parameters. It seems this case usually does not arise when we compile
from source because A or B or both are eta expanded. But it can arise after unpickling.