Skip to content

Publish Dotty baseVersion when generating Documentation #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2017

Conversation

allanrenucci
Copy link
Contributor

No description provided.

@allanrenucci allanrenucci requested a review from smarter October 24, 2017 11:29
@smarter
Copy link
Member

smarter commented Oct 24, 2017

I suggest also writing the latest nightly version to a file when publishing a nightly build, that way dottyLatestNightlyBuild can just fetch that file.

@smarter
Copy link
Member

smarter commented Oct 24, 2017

I would call the files versions/latest-rc and versions/latest-nightly

@allanrenucci
Copy link
Contributor Author

allanrenucci commented Oct 24, 2017

I am only writing the base version on purpose. The reason is that I haven't found a good solution to keep the nightly version that would be on the website in sync with what is on maven.

If I write down the nightly version at the time we publish a nightly, then the website will list a version that is not yet on maven (it takes quite some time ~30min). That means that dottyLatestNightlyBuild will be broken for ~30min every days which is pretty bad.

@allanrenucci
Copy link
Contributor Author

The actual solution is a bit hacky, but at least dottyLatestNightlyBuild works all the time. Another solution would be to fetch the latest nightly version from maven and write it down when we publish the doc. The downside, is that dottyLatestNightlyBuild will not always return the latest nightly

@smarter
Copy link
Member

smarter commented Oct 24, 2017

OK I see.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a key=value property file, I would just use multiple files. For example here versions/latest-nightly-base

@allanrenucci allanrenucci merged commit ec54e63 into scala:master Oct 29, 2017
@allanrenucci allanrenucci deleted the fix-#2806 branch October 29, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants