Skip to content

move 'extend final class' to error class #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public enum ErrorMessageID {
NoReturnFromInlineID,
ReturnOutsideMethodDefinitionID,
UncheckedTypePatternID,
ExtendFinalClassID,
;

public int errorNumber() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1770,4 +1770,12 @@ object messages {
|"""
}

case class ExtendFinalClass(clazz:Symbol, finalClazz: Symbol)(implicit ctx: Context)
extends Message(ExtendFinalClassID) {
val kind = "Syntax"
val msg = hl"$clazz cannot extend ${"final"} $finalClazz"
val explanation =
hl"""A class marked with the ${"final"} keyword cannot be extended"""
}

}
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Namer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ class Namer { typer: Typer =>
else {
val pclazz = pt.typeSymbol
if (pclazz.is(Final))
ctx.error(em"cannot extend final $pclazz", cls.pos)
ctx.error(ExtendFinalClass(cls, pclazz), cls.pos)
if (pclazz.is(Sealed) && pclazz.associatedFile != cls.associatedFile)
ctx.error(em"cannot extend sealed $pclazz in different compilation unit", cls.pos)
pt
Expand Down
12 changes: 12 additions & 0 deletions compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala
Original file line number Diff line number Diff line change
Expand Up @@ -998,4 +998,16 @@ class ErrorMessagesTests extends ErrorMessagesTest {
val ReturnOutsideMethodDefinition(owner) :: Nil = messages
assertEquals("object A", owner.show)
}
@Test def extendFinalClass = checkMessagesAfter("refchecks") {
"""final class A
|
|class B extends A
""".stripMargin
}.expect { (ictx, messages) =>
implicit val ctx: Context = ictx
assertMessageCount(1, messages)
val ExtendFinalClass(extender, parent) :: Nil = messages
assertEquals(extender.show, "class B")
assertEquals(parent.show, "class A")
}
}