Micro-optimization: Symbol#denot #3263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 7 job(s) in queue, 1 running. |
odersky
force-pushed
the
try-optimize-7
branch
2 times, most recently
from
c227587 to
5e6278e
Compare
|
test performance please |
|
performance test scheduled: 5 job(s) in queue, 1 running. |
odersky
force-pushed
the
try-optimize-7
branch
from
834f135 to
f2cdce8
Compare
Make the overridden method less frequently called
|
The benchmark test is currently running for this PR, should finish in about 40min. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3263/ to see the changes. Benchmarks is based on merging with master (c50c164) |
smarter
approved these changes
Oct 6, 2017
| if (lastd.validFor contains now) lastd else recomputeDenot(lastd) | ||
| } | ||
|
|
||
| /** Overridden in NoSymbol */ |
There was a problem hiding this comment.
Not sure if it'll help performance, but have you tried doing if (this eq NoSymbol) NoDenotation else ... to avoid the override?
There was a problem hiding this comment.
I have not tired it. I don't think we'd see a difference either way. Would be good to know more about tradeoffs like this, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.