Replace private var by private[this] var where possible
#3241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
private-this-var
branch
from
7926a5c to
9b71563
Compare
|
Why do it? It does not make the code more beautiful, for sure. |
|
Makes the intended usage more explicit, and it generates less bytecode (direct field access instead of accessor method calls). I agree that the syntax is not the nicest, I think @Ichoran suggested |
smarter
force-pushed
the
private-this-var
branch
from
9b71563 to
3855e76
Compare
|
test performance please |
|
performance test scheduled: 14 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3241/ to see the changes. Benchmarks is based on merging with master (de7b370) |
|
How much less bytecode is generated? Performance data don't indicate a change in speed. |
smarter
force-pushed
the
private-this-var
branch
from
3855e76 to
444a189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.