Skip to content

Fix #3171: Fix handling default getters in secondary constructors #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 28, 2017

Previous logic would place them in the enclosing class instead of in
the companion object where they belong.

Also, define position for error that checks against multiple overloaded
alternatives with default arguments.

Previous logic would place them in the enclosing class instead of in
the companion object where they belong.

Also, define position for error that checks against multiple overloaded
alternatives with default arguments.
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit e208878 into scala:master Sep 28, 2017
@allanrenucci allanrenucci deleted the fix-#3171 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants