Fix #3168: Don't insert apply if tree has method type #3198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You mean #3168 not 3169 |
smarter
approved these changes
Sep 27, 2017
odersky
changed the title
|
Yes, indeed. #3168. |
|
Your first commit message also refers to 3169 instead of 3168 |
|
Needs rebase |
It would be simply an eta-expansion followed by an application. As scala#3168 shows, overloading resolution gets confused by this.
- also rework previous test of scala#3189 to be a run test, just to make sure the problem is solved.
This one verifies that we still need the `isSyntheticApply` condition in the test whether to elide an `apply` insertion attempt.
allanrenucci
force-pushed
the
fix-#3168
branch
from
377ecd1 to
c6b65cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be simply an eta-expansion followed by an application.
As #3168 shows, overloading resolution gets confused by this.