Skip to content

Only execute optimised/idempotency test on Drone #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@smarter
Copy link
Member

smarter commented Sep 27, 2017

What if I really want to run them locally because they failed on drone?

@nicolasstucki
Copy link
Contributor Author

You comment out the jUnit assumptions

@allanrenucci
Copy link
Contributor

What about we move testOptimised to its own class instead. So that someone can do testOnly CompilationTests if he does not want to run the optimised tests?

@nicolasstucki
Copy link
Contributor Author

@odersky wanted it to work form Eclipse out of the box, the testOnly will not work in that scenario.

@odersky
Copy link
Contributor

odersky commented Oct 1, 2017

Actually, I don't care about Eclipse anymore... But I think it's worthwhile to have a subset of tests that cover the essential aspects of what likely goes wrong, and that don't take a huge amount of time. We can get a much better workflow for developing that way. For me personally, the tests that matter are in particular, pos, neg, run, testPickler, tastyBootstrap, and the repl tests. The others are not a problem either because they don't take much time anyway. Except for idempotent and optimized. I think it's really rare that these go wrong in isolation. And they do both take a lot of time.

@odersky odersky merged commit 0ed66e4 into scala:master Oct 1, 2017
@odersky
Copy link
Contributor

odersky commented Oct 1, 2017

Actually, I think I merged this too early. The fact that we have to edit the build script to test these locally is bad.

@nicolasstucki Can we change this so that optimised and idempotency can still be run as test-only targets, but are not run under test?

nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Oct 1, 2017
@nicolasstucki
Copy link
Contributor Author

With #3227 we can run those tests with testOnly but they are ignored with the other ones.

nicolasstucki added a commit to dotty-staging/dotty that referenced this pull request Oct 2, 2017
nicolasstucki referenced this pull request Oct 3, 2017
Allow running long tests with testOnly
@allanrenucci allanrenucci deleted the only-on-drone branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants