-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Only execute optimised/idempotency test on Drone #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37deb8b
to
337f604
Compare
What if I really want to run them locally because they failed on drone? |
You comment out the jUnit assumptions |
What about we move |
@odersky wanted it to work form Eclipse out of the box, the |
Actually, I don't care about Eclipse anymore... But I think it's worthwhile to have a subset of tests that cover the essential aspects of what likely goes wrong, and that don't take a huge amount of time. We can get a much better workflow for developing that way. For me personally, the tests that matter are in particular, pos, neg, run, testPickler, tastyBootstrap, and the repl tests. The others are not a problem either because they don't take much time anyway. Except for idempotent and optimized. I think it's really rare that these go wrong in isolation. And they do both take a lot of time. |
Actually, I think I merged this too early. The fact that we have to edit the build script to test these locally is bad. @nicolasstucki Can we change this so that optimised and idempotency can still be run as test-only targets, but are not run under |
With #3227 we can run those tests with |
No description provided.