Skip to content

Add missing case in factories #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

Add missing case in factories #3157

merged 1 commit into from
Sep 22, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 22, 2017

No description provided.

@odersky odersky requested a review from felixmulder September 22, 2017 10:09
@odersky
Copy link
Contributor Author

odersky commented Sep 22, 2017

Merging now to unbreak the build

@allanrenucci
Copy link
Contributor

This fixes #3155. Can we add a test case for it?

@allanrenucci
Copy link
Contributor

@odersky Could you give me a code snippet that produces a TypeArgRef and used to break the documentation. I can make a test case out of it.

@odersky
Copy link
Contributor Author

odersky commented Sep 22, 2017 •
edited
Loading

@allanrenucci TypeArgRefs will probably go away again soon, so I think it's not worth making a test case for them now.

allanrenucci
allanrenucci approved these changes Sep 22, 2017
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allanrenucci allanrenucci merged commit 7594483 into scala:master Sep 22, 2017
@allanrenucci allanrenucci mentioned this pull request Sep 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

@felixmulder felixmulder Awaiting requested review from felixmulder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @allanrenucci