Disable context escape detection #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get very frequent build failures due to the mutual Scala<->Java dependency. It builds for a long time, then decides that getCtx overrides nothing. The only way to fix is another clean build. Total time lost: >5 minutes. These happened occasionally before but have become much more frequent under ScalaIDe4.0, to the point where this becomes a major drag on productity. Context escape detection is nice but if it stops us getting work done, not worth the effort.
|
@odersky I'm not sure I understand what is the problem. Is it a bug in ScalaIDE? Would rewriting ContextEscapeDetection in scala help? |
|
I think it's a bug in the SBT builder who chokes on the mutual Scala/Java dependencies in certain situations. Rewriting in Scala would probably help. |
DarkDimius
added a commit
that referenced
this pull request
Dec 21, 2014
Disable context escape detection
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Lazy val def member is pattern var" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get very frequent build failures due to the mutual Scala<->Java dependency in
context escape detection.
It builds for a long time, then decides that getCtx overrides nothing. The only
way to fix is another clean build. Total time lost: >5 minutes. These happened
occasionally before but have become much more frequent under ScalaIDE4.0, to the
point where this becomes a major drag on productity. Context escape detection
is nice but if it stops us getting work done, not worth the effort.
Review by @DarkDimius