Infrastructure for per-phase tests, with inline source as a string. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It is a bit unfortunate that we have to write the source to a file. We should have a follow up enabling the compiler to compile a compilation unit from a string directly. |
DarkDimius
added a commit
that referenced
this pull request
Mar 2, 2014
Infrastructure for per-phase tests, with inline source as a string.
DarkDimius
added a commit
to DarkDimius/dotty
that referenced
this pull request
Mar 2, 2014
Infrastructure for per-phase tests, with inline source as a string.
DarkDimius
added a commit
to DarkDimius/dotty
that referenced
this pull request
Mar 2, 2014
Infrastructure for per-phase tests, with inline source as a string.
|
VirtualFile allows this, I think @xeno-by has done this before. As is, this is likely to break on Jenkins/Travis. |
|
AFAIK both jenkins and travis allow to use OS specific ways to create temporary files, as otherwise most tools will just stop working. |
|
You're probably right, but interacting with the filesystem has the weirdest gotchas. In the long run, it's worth avoiding IMO. |
noti0na1
pushed a commit
to noti0na1/dotty
that referenced
this pull request
Oct 22, 2019
Merge Changes from Dotty Upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a sample test.