Skip to content

Use new docker image with updated cache after the switch to 2.12 #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2017
Merged

Use new docker image with updated cache after the switch to 2.12 #3035

merged 2 commits into from
Aug 30, 2017

Conversation

OlivierBlanvillain
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain commented Aug 30, 2017 •
edited
Loading

@felixmulder
Copy link
Contributor

Gotta sign the file mate drone sign lampepfl/dotty 👍

@allanrenucci
Copy link
Contributor

I guess you should update all the images in the file

@allanrenucci
Copy link
Contributor

allanrenucci commented Aug 30, 2017 •
edited
Loading

From my understanding we set pull: true in the drone.yml file to always pull the latest image. However, to have the latest image we should write image:lampepfl/dotty:latest and a specific version.
Am I missing something?

/ref http://docs.drone.io/images/

@OlivierBlanvillain
Copy link
Contributor Author

Tags of docker images are mutable, with pull: true drone will always ask docker-hub, "hey is the latest version of lampepfl/dotty:2017-08-30". I guess it could be removed since the plan is to keep all images for better reproducibility :)

@OlivierBlanvillain
Remove pull: true from drone.yml
1614c5e 
Tags of docker images are mutable, with `pull: true drone` will always ask
docker-hub, "hey is the latest version of lampepfl/dotty:2017-08-30?". Since
the plan to keep all images and create a new one when needed this option can
be removed.
felixmulder
felixmulder approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlivierBlanvillain OlivierBlanvillain merged commit 815eb8b into scala:master Aug 30, 2017
@OlivierBlanvillain OlivierBlanvillain deleted the update-docker-image branch August 30, 2017 09:45
@OlivierBlanvillain OlivierBlanvillain mentioned this pull request Aug 30, 2017
Closed
allanrenucci added a commit to allanrenucci/dotty that referenced this pull request Aug 31, 2017
@allanrenucci
Revert scala#3035
ce533fe
@allanrenucci allanrenucci mentioned this pull request Aug 31, 2017
Merged
nicolasstucki added a commit that referenced this pull request Aug 31, 2017
@nicolasstucki
Merge pull request #3038 from allanrenucci/fix-drone
0e3848b 
Revert #3035
allanrenucci added a commit to allanrenucci/dotty that referenced this pull request Aug 31, 2017
@allanrenucci
Revert "Revert scala#3035"
f155322 
This reverts commit ce533fe.
allanrenucci added a commit that referenced this pull request Aug 31, 2017
@allanrenucci
Merge pull request #3042 from allanrenucci/revert-3038
909ae1f 
Revert "Revert #3035"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixmulder felixmulder felixmulder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlivierBlanvillain @felixmulder @allanrenucci