Fix #2971: Soudness issue with variance and higher kinded types #2975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't use `HKApply#superType` in `isRef`, because this means taking the upper bound of abstract type constructors.
|
There's one test failure which is extremely annoying because it only happens when compiling all of the neg tests, even though the failure is in > vulpix tests/neg
# fails (but not everytime)
> vulpix tests/neg/i1650.scala
# succeedsHere's the stacktrace extracted from the log: Any idea what's going on? |
Calling HKTypeLambda#member will crash when trying to form a NamedType, this happened in `compareRefinedSlow` so we now skip it. If this HKTypeLambda is an eta-expansion it will be handled by `fourthTry`. Somehow, this only started happening after the last commit, when running: > vulpix tests/neg But it's not deterministic, multiple runs may be necessary. The crash happened while compiling i1650.scala, but compiling this file by itself didn't trigger the failure.
|
Pushed a fix, though it's a bit kludgy to add special cases like that. |
odersky
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't use
HKApply#superTypeinisRef, because this meanstaking the upper bound of abstract type constructors.