Skip to content

Vulpix should catch and report all exceptions during compilation of test cases #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

gsps
Copy link
Contributor

@gsps gsps commented Aug 2, 2017

Vulpix currently only catches NonFatal exceptions in tryCompile, silently omitting exceptions such as those for stack overflows. Worse yet, such exceptions are then caught somewhere higher up in vulpix, but registerCompletion(1) is never called for the respective failing test cases, causing vulpix to hang in an idle state.

Vulpix should arguably catch all sorts of exceptions and also report the respective stack traces. I'd be grateful if someone also pointed out where such fatal exceptions were currently caught, perhaps that exception handler higher up should actually abort testing.

@gsps gsps requested a review from felixmulder August 2, 2017 13:11
@felixmulder felixmulder merged commit 3b24064 into scala:master Aug 2, 2017
@felixmulder
Copy link
Contributor

felixmulder commented Aug 2, 2017

From a quick glance at the java ExecutorService API you can gleam that the thread pool returns a future on pool.submit and that said future is never "gotten" just executed by side-effect. Thus, what happens - is most likely - that the exception bleeds out into stderr, but never kills the executor service.

I'm sort of feeling that this is a feature rather than a bug (with the exception (get it? haha) of your change to catch all). But, maybe there's something I'm not seeing....

@gsps
Copy link
Contributor Author

gsps commented Aug 2, 2017

Fair enough, I guess now that we catch all exceptions during compilation in that one place it won't be a problem anyways. Thanks for looking into it!

@gsps gsps deleted the vulpix-report-all-exceptions branch August 2, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants