Vulpix should catch and report all exceptions during compilation of test cases #2942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulpix currently only catches
NonFatal
exceptions intryCompile
, silently omitting exceptions such as those for stack overflows. Worse yet, such exceptions are then caught somewhere higher up in vulpix, butregisterCompletion(1)
is never called for the respective failing test cases, causing vulpix to hang in an idle state.Vulpix should arguably catch all sorts of exceptions and also report the respective stack traces. I'd be grateful if someone also pointed out where such fatal exceptions were currently caught, perhaps that exception handler higher up should actually abort testing.