Skip to content

Fix #2772: Special case Devalify for java.lang.System.* #2781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2017
Merged

Fix #2772: Special case Devalify for java.lang.System.* #2781

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be8bcee
Fix #2772: Special case Devalify for java.lang.System.*
OlivierBlanvillain Jun 19, 2017
f4c19d9
Slight Devalify refactorings
OlivierBlanvillain Jun 19, 2017
faa8864
Indentation
OlivierBlanvillain Jun 19, 2017
cd035b2
Factor out isMutable logic, use it in DropGoodCasts
OlivierBlanvillain Jun 19, 2017
f824164
Document that local optimisations assumes final fields are final
OlivierBlanvillain Jun 19, 2017
cf54051
Adress review
OlivierBlanvillain Jun 20, 2017
09d4a8c
Use symbol.owner
OlivierBlanvillain Jun 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/docs/reference/optimisations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
layout: doc-page
title: "Local Optimisations"
---

The Dotty compiler implements several local optimisations to generate faster bytecode. These optimisations can be enabled by compiling with the `-optimise` flag. The current best source of documentation about what tree transformations are performed under `-optimise` is the Scaladoc classes in the [localopt package](https://github.com/lampepfl/dotty/tree/master/compiler/src/dotty/tools/dotc/transform/localopt).

Local optimisations assumes no use of Java Reflection to mutate static final fields.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about non-static final fields, are those safe to mutate?

2 changes: 2 additions & 0 deletions docs/sidebar.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ sidebar:
url: docs/reference/auto-parameter-tupling.html
- title: Named Type Arguments
url: docs/reference/named-typeargs.html
- title: Local Optimisations
url: docs/reference/optimisations.html
- title: Changed Features
subsection:
- title: Volatile Lazy Vals
Expand Down