Detect direct cycles of typerefs referring to themselves #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
add-check-cycles
branch
from
f3ec774 to
0295cc4
Compare
DarkDimius
reviewed
Jun 14, 2017
| /** If this flag is set, it is checked that TypeRefs don't refer directly | ||
| * to themselves. | ||
| */ | ||
| final val checkTypeRefCycles = true |
There was a problem hiding this comment.
should be false by default
Have a Config option that allows to flag as assertion errors typerefs that refer directly to themselves in a bound or alias. I am going to use this to track down isRef stackoverflows; I believe it is also useful to keep around in case similar errors appear later.
Caused cyclic reference exceptions before
odersky
force-pushed
the
add-check-cycles
branch
from
5c2de4e to
d69fb6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a Config option that allows to flag as assertion errors
typerefs that refer directly to themselves in a bound or alias.
I am going to use this to track down isRef stackoverflows in the IDE; I believe
it is also useful to keep around in case similar errors appear later.