Skip to content

Add VSCode settings for the dotty project #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 12, 2017
Merged

Add VSCode settings for the dotty project #2750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
227a102
Add VSCode settings for the dotty project
nicolasstucki Jun 14, 2017
bd84d36
Remove Trailing whitespaces
nicolasstucki Jun 14, 2017
151d6b1
Make template for .vscode/settings.json
nicolasstucki Jun 15, 2017
351b10c
vscode exclude files in scala2-library and scala-backend
nicolasstucki Jun 15, 2017
37b18f5
Fix typo
nicolasstucki Jun 15, 2017
1e479be
Move vs code template to .vscode-template/
nicolasstucki Jun 15, 2017
cd2dbf3
Add missing space
nicolasstucki Jun 19, 2017
1f4fb2b
Fix issue with **
nicolasstucki Jun 19, 2017
1fdb0e6
Exclude files in target
nicolasstucki Jun 19, 2017
caa6186
Use sbt.IO.copyDirectory
nicolasstucki Jun 19, 2017
eda5730
Change regex ending with "/*" to end with "/"
nicolasstucki Jul 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ project/local-plugins.sbt
# npm
node_modules

# VS Code
.vscode/

# Scala-IDE specific
.scala_dependencies
.cache
Expand Down
0 .vscode/settings.json → .vscode/settings-template.json
View file
Open in desktop
File renamed without changes.
11 changes: 9 additions & 2 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ object Build {
settings(commonNonBootstrappedSettings).
settings(
triggeredMessage in ThisBuild := Watched.clearWhenTriggered,
submoduleChecks,
dottyProjectFolderChecks,

addCommandAlias("run", "dotty-compiler/run") ++
addCommandAlias("legacyTests", "dotty-compiler/testOnly dotc.tests")
Expand Down Expand Up @@ -1138,7 +1138,7 @@ object Build {
))
}

lazy val submoduleChecks = onLoad in Global := (onLoad in Global).value andThen { state =>
lazy val dottyProjectFolderChecks = onLoad in Global := (onLoad in Global).value andThen { state =>
val submodules = List(new File("scala-backend"), new File("scala2-library"), new File("collection-strawman"))
if (!submodules.forall(f => f.exists && f.listFiles().nonEmpty)) {
sLog.value.log(Level.Error,
Expand All @@ -1147,6 +1147,13 @@ object Build {
| > git submodule update --init
""".stripMargin)
}

val vscodeSetting = new File(".vscode/settings.json")
if(!vscodeSetting.exists()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after if

val vscodeSettingTemplate = new File(".vscode/settings-template.json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a .vscode-template directory instead:

  • We might want to add settings for other files in .vscode
  • This means that it's safe to gitignore everything in .vscode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add a comment explaining what this does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

java.nio.file.Files.copy(vscodeSettingTemplate.toPath, vscodeSetting.toPath)
}

state
}

Expand Down