Skip to content

Fix #2642: Disallow nullary implicit function types #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2017
Merged

Fix #2642: Disallow nullary implicit function types #2645

merged 2 commits into from
Jun 1, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 1, 2017

It makes no sense to have a nullary implicit function type, so should disallow it.

@odersky odersky requested a review from nicolasstucki June 1, 2017 11:52
@nicolasstucki
Copy link
Contributor

@odersky I wrote a couple of comments on the commit directly, before the PR was open.

nicolasstucki
nicolasstucki suggested changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In NameOps: functionArity, isFunction, isImplicitFunction and isSyntheticFunction must be updated as well.

@odersky
Copy link
Contributor Author

odersky commented Jun 1, 2017

In NameOps: functionArity, isFunction, isImplicitFunction and isSyntheticFunction must be updated as well.

Good catch.

@odersky odersky merged commit 3a66d73 into scala:master Jun 1, 2017
@allanrenucci allanrenucci deleted the fix-#2642 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @nicolasstucki