Don't use empty files to indicate presence of tasty in class path. #2569
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Added" instead of "Add")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
@smarter are IDE tests run by default? |
|
@DarkDimius There are no IDE tests currently :). |
| @@ -86,10 +86,10 @@ class InteractiveDriver(settings: List[String]) extends Driver { | |||
| else | |||
| null | |||
| prefix != null && { | |||
| val tastyFile = prefix + ".tasty" | |||
| val hasTastyFile = prefix + ".hasTasty" | |||
There was a problem hiding this comment.
This won't work correctly if YemitTasty is enabled.
|
.tasty handling in sbt-dotty: https://github.com/lampepfl/dotty/blob/master/sbt-dotty/src/dotty/tools/sbtplugin/DottyPlugin.scala#L100 |
| if (f.exists) List(f) | ||
| else Nil | ||
| val prefix = classFile.getAbsolutePath.stripSuffix(".class") | ||
| List(".tasty", ".hasTasty").map(x => new File(prefix + x)).filter(_.exists) |
There was a problem hiding this comment.
Documentation above this method needs to be updated to talk about .hasTasty files too.
|
ping @smarter. The doc was updated. Anything else? In absence of tests it's tricky to know) |
|
@smarter, why did you terminate the CI? |
| @@ -214,7 +214,8 @@ class GenBCodePipeline(val entryPoints: List[Symbol], val int: DottyBackendInter | |||
| } else if (!outTastyFile.isVirtual) { | |||
| // Create an empty file to signal that a tasty section exist in the corresponding .class | |||
| // This is much cheaper and simpler to check than doing classfile parsing | |||
| outTastyFile.create() | |||
| val hasTasty = getFileForClassfile(outF, store.name, ".hasTasty") | |||
There was a problem hiding this comment.
It turns out that getFileForClassfile will automatically create an empty file, so we are now creating both ".tasty" and ".hasTasty" files, I'll fix it :).
For now, we'll only use .tasty files when we actually store a tasty section in them. This requires release a new version of sbt-dotty to deal with deleting .hasTasty files.
Use hasTasty files instead.