Skip to content

Fix #2492: Avoid typing the body when self has error type #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2017

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@DarkDimius
Copy link
Contributor

@nicolasstucki, needs rebase

@nicolasstucki
Copy link
Contributor Author

Rebased

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@@ -466,6 +466,7 @@ trait TypeAssigner {
val rsym = refinement.symbol
val rinfo = if (rsym is Accessor) rsym.info.resultType else rsym.info
if (rinfo.isError) rinfo
else if (rinfo eq NoType) parent // can happen after failure in self type definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if !rinfo.exists

@nicolasstucki nicolasstucki merged commit 5f1a8de into scala:master May 28, 2017
@allanrenucci allanrenucci deleted the fix-#2492 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants