Skip to content

[scaladays] dottydoc improvements 2 #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2017
Merged

[scaladays] dottydoc improvements 2 #2503

merged 7 commits into from
May 23, 2017

Conversation

felixmulder
Copy link
Contributor

This PR is best detailed by the commit messages. Github previously panicked since the AST index was too large (>200mb) it is now around 4mb for the dotty project.

@felixmulder felixmulder requested a review from nicolasstucki May 22, 2017 15:57
@felixmulder felixmulder force-pushed the topic/dottydoc-scaladays-2k17-2 branch from 4fcb928 to f3a3bf3 Compare May 22, 2017 15:59
@nicolasstucki
Copy link
Contributor

There is a small issue, texts from Entry Results can overflow to to Member Result column. The are a couple of bol), List()) overflowing in this example.
screen shot 2017-05-23 at 14 10 57

nicolasstucki
nicolasstucki approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The overflow issue could be left for next PR

@felixmulder felixmulder merged commit de2fd79 into scala:master May 23, 2017
@felixmulder felixmulder deleted the topic/dottydoc-scaladays-2k17-2 branch May 23, 2017 13:15
liufengyun added a commit to dotty-staging/dotty that referenced this pull request Mar 16, 2020
@liufengyun
Fix scala#7644: silence debug warnings in REPL
a11f887 
Otherwise, we will print the following in the REPL, which should not be the default.

stale symbol; module class rs$line$1$scala#2503 in module class <empty>, defined in Period(1..4, run = 2), is referred to in run Period(1..1, run = 3)
stale symbol; class T#3334 in module class rs$line$1$, defined in Period(1..4, run = 2), is referred to in run Period(1..1, run = 3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
area:doctool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixmulder @nicolasstucki