Handle case where typevar instance is fully determined #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biboudis
reviewed
May 15, 2017
Need another check whether a constraint contains a typevariable before going ahead with instantiating it. Test case in collection strawman: `List.empty ++ List.empty`.
odersky
force-pushed
the
fix-strawman-compile-4
branch
from
7e3f5ab to
30fa29a
Compare
DarkDimius
approved these changes
May 16, 2017
|
@biboudis - add minimized test then merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a type parameter in a constraint gets instantiated via
a unification operation. In that case, the type parameter does not have
a TypeBounds instance associated with it, so is not considered to be
contained in the constraint. But it must still be possible to instantiate
a type variable corresponding to this parameter.
Test case in collection strawman:
List.empty ++ List.empty.