Fix #2404: Fixes to make collections strawman compile, take 3 #2408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature might need to be updated if the symbol has a different type as seen from the new prefix.
odersky
force-pushed
the
fix-compile-strawman-3
branch
from
f194388 to
7a1f187
Compare
2 tasks
Need to keep all consistent parts of original signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is needed to compile
scala/collection-strawman#64.
It affects a core part of type handling: How to adapt signatures when copying
TermRefWithSig trees. So far signatures were kept as before, which is incorrect if
the new prefix "sees" the symbol with different type as the old one. The problem
manifested itself by inlining failures.